这段代码可以重构为更短的代码吗？

分类：编程问答

如何解决这段代码可以重构为更短的代码吗？

我有以下代码

let objProvince = paramsData.find(element => element.name === "province")
      if (objProvince) {
        let error = false;
        if (objProvince.value === "VI" && value.substring(0,2) !== "01") error = true
        if (objProvince.value === "AB" && value.substring(0,2) !== "02") error = true
        if (objProvince.value === "A" && value.substring(0,2) !== "03") error = true
        if (objProvince.value === "AL" && value.substring(0,2) !== "04") error = true
        if (objProvince.value === "AV" && value.substring(0,2) !== "05") error = true
        if (objProvince.value === "BA" && value.substring(0,2) !== "06") error = true
        if (objProvince.value === "PM" && value.substring(0,2) !== "07") error = true
        if (objProvince.value === "B" && value.substring(0,2) !== "08") error = true
        if (objProvince.value === "BU" && value.substring(0,2) !== "09") error = true
        if (objProvince.value === "CC" && value.substring(0,2) !== "10") error = true
        if (objProvince.value === "CA" && value.substring(0,2) !== "11") error = true
        if (objProvince.value === "CS" && value.substring(0,2) !== "12") error = true
        if (objProvince.value === "CR" && value.substring(0,2) !== "13") error = true
        if (objProvince.value === "CO" && value.substring(0,2) !== "14") error = true
        if (objProvince.value === "C" && value.substring(0,2) !== "15") error = true
        if (objProvince.value === "CU" && value.substring(0,2) !== "16") error = true
        if (objProvince.value === "GI" && value.substring(0,2) !== "17") error = true
        if (objProvince.value === "GR" && value.substring(0,2) !== "18") error = true
        if (objProvince.value === "GU" && value.substring(0,2) !== "19") error = true
        if (objProvince.value === "SS" && value.substring(0,2) !== "20") error = true
        if (objProvince.value === "H" && value.substring(0,2) !== "21") error = true
        if (objProvince.value === "HU" && value.substring(0,2) !== "22") error = true
        if (objProvince.value === "J" && value.substring(0,2) !== "23") error = true
        if (objProvince.value === "LE" && value.substring(0,2) !== "24") error = true
        if (objProvince.value === "L" && value.substring(0,2) !== "25") error = true
        if (objProvince.value === "LO" && value.substring(0,2) !== "26") error = true
        if (objProvince.value === "LU" && value.substring(0,2) !== "27") error = true
        if (objProvince.value === "M" && value.substring(0,2) !== "28") error = true
        if (objProvince.value === "MA" && value.substring(0,2) !== "29") error = true
        if (objProvince.value === "MU" && value.substring(0,2) !== "30") error = true
        if (objProvince.value === "MA" && value.substring(0,2) !== "31") error = true
        if (objProvince.value === "OR" && value.substring(0,2) !== "32") error = true
        if (objProvince.value === "O" && value.substring(0,2) !== "33") error = true
        if (objProvince.value === "P" && value.substring(0,2) !== "34") error = true
        if (objProvince.value === "GC" && value.substring(0,2) !== "35") error = true
        if (objProvince.value === "PO" && value.substring(0,2) !== "36") error = true
        if (objProvince.value === "SA" && value.substring(0,2) !== "37") error = true
        if (objProvince.value === "TF" && value.substring(0,2) !== "38") error = true
        if (objProvince.value === "S" && value.substring(0,2) !== "39") error = true
        if (objProvince.value === "SG" && value.substring(0,2) !== "40") error = true
        if (objProvince.value === "SE" && value.substring(0,2) !== "41") error = true
        if (objProvince.value === "SO" && value.substring(0,2) !== "42") error = true
        if (objProvince.value === "T" && value.substring(0,2) !== "43") error = true
        if (objProvince.value === "TE" && value.substring(0,2) !== "44") error = true
        if (objProvince.value === "TO" && value.substring(0,2) !== "45") error = true
        if (objProvince.value === "V" && value.substring(0,2) !== "46") error = true
        if (objProvince.value === "VA" && value.substring(0,2) !== "47") error = true
        if (objProvince.value === "BI" && value.substring(0,2) !== "48") error = true
        if (objProvince.value === "ZA" && value.substring(0,2) !== "49") error = true
        if (objProvince.value === "Z" && value.substring(0,2) !== "50") error = true
        if (objProvince.value === "CE" && value.substring(0,2) !== "51") error = true
        if (objProvince.value === "ML" && value.substring(0,2) !== "52") error = true

        if (error) {............

看起来很大，但我不确定如何缩短它。

我正在考虑做类似的事情：

const provinces = ["VI","AB","A","AL","AV","BA","PM","B","BU","CC","CA","CS","CR","CO","C","CU","GI","GR","GU","SS","H","HU","J","LE","L","LO","LU","M","MA","MU","OR","O","P","GC","PO","SA","TF","S","SG","SE","SO","T","TE","TO","V","VA","BI","ZA","Z","CE","ML"]


function proviceCheck (_provinceValue) {
    let indexPosition = array.indexOf(_provinceValue) + 1;
    let formatedIndex = ""
    
    if(indexPosition < 10){
        formatedIndex = ('0'+indexPosition).slice(-2);
    }else{
        formatedIndex = indexPosition.toString()
    }
    
    if(provinces.includes(_provinceValue) && provinceValue.substring(0,2) !== formatedIndex return true;
    
    return false;
} 

if(objProvince){
    let error = false;
    error = provinceCheck(objProvince.value)
    
    if(error) {......
}

问题在于数组 28 和 30 的索引重复，所以我不能使用我拥有的 indexOf 想法。

还有其他想法可以重构吗？也许有一些功能代码。但我不知道其他任何解决方案。

请注意，我上面的解决方案已损坏，因为数组具有重复的索引值 28 == 30

解决方法

我会反过来 - 提取索引，然后检查 _provinceValue 是否匹配：

function proviceCheck (_provinceValue) {
    const index = Number(provinceValue.substring(0,2)) - 1;

    return provinces[index] === _provinceValue;
}
,

为了避免索引错误，您可以做的是通过循环遍历省数组中的所有省，在所有省名称旁边生成一个数字，我会这样做：

const provinces = ["VI","AB","A","AL","AV","BA","PM"].map((a,b) => {'name': a,'index': b}]);

现在您可以执行 provinces[index].name 来获取名称和 provinces[index].index 获取它的索引

,

你可以通过一个字典来简化逻辑，并使用这样的字典来验证返回的对象值是一个已知的键，并且它的值是正确的。

const provinces = {
  "VI": "01","AB": "02","A": "03","AL": "04","AV": "05","BA": "06","PM": "07","B": "08","BU": "09","CC": "10","CA": "11",// the rest ...
};

objProvince = paramsData.find(element => element.name === "province");
let error = false;
if (objProvince && provinces.hasOwnProperty(objProvince.value))
  error = value.substring(0,2) !== provinces[objProvince.value];

版权声明：本文内容由互联网用户自发贡献，该文观点与技术仅代表作者本人。本站仅提供信息存储空间服务，不拥有所有权，不承担相关法律责任。如发现本站有涉嫌侵权/违法违规的内容， 请发送邮件至 dio@foxmail.com 举报，一经查实，本站将立刻删除。

相关推荐

导入项目后报错问题
依赖报错 idea导入项目后依赖报错，解决方案：https://blog.csdn.net/weixin_42420249/article/details/81191861 依赖版本报错：更换其他版本 无法下载依赖可参考：https://blog.csdn.net/weixin_42628809/a
idea不能识别yaml文件
使用mybatis plus常见错误
错误1：代码生成器依赖和mybatis依赖冲突 启动项目时报错如下 2021-12-03 13:33:33.927 ERROR 7228 [ main] o.s.b.d.LoggingFailureAnalysisReporter : *************************** APPL
gradle常见问题与错误
错误1：gradle项目控制台输出为乱码 # 解决方案：https://blog.csdn.net/weixin_43501566/article/details/112482302 # 在gradle-wrapper.properties 添加以下内容 org.gradle.jvmargs=-Df
Mybatis Plus传入参数0不起作用
错误还原：在查询的过程中，传入的workType为0时，该条件不起作用 &lt;select id=&quot;xxx&quot;&gt; SELECT di.id, di.name, di.work_type, di.updated... &lt;where&gt; &lt;if test=&qu
linux中make编译源码包失败
报错如下，gcc版本太低 ^ server.c:5346:31: 错误：‘struct redisServer’没有名为‘server_cpulist’的成员 redisSetCpuAffinity(server.server_cpulist); ^ server.c: 在函数‘hasActiveC
微服务启动错误：Command line is too long. Shorten command line for
解决方案1 1、改项目中.idea/workspace.xml配置文件，增加dynamic.classpath参数 2、搜索PropertiesComponent，添加如下 &lt;property name=&quot;dynamic.classpath&quot; value=&quot;tru
vue常见错误
删除根组件app.vue中的默认代码后报错：Module Error (from ./node_modules/eslint-loader/index.js): 解决方案：关闭ESlint代码检测，在项目根目录创建vue.config.js，在文件中添加 module.exports = { lin
spark常见错误
查看spark默认的python版本 [root@master day27]# pyspark /home/software/spark-2.3.4-bin-hadoop2.7/conf/spark-env.sh: line 2: /usr/local/hadoop/bin/hadoop: No s
matplotlib报错：AttributeError: module 'backend_interagg' has no attribute 'FigureCanvas'. Did you mean: 'FigureCanvasAgg'?
使用本地python环境可以成功执行 import pandas as pd import matplotlib.pyplot as plt # 设置字体 plt.rcParams[&#39;font.sans-serif&#39;] = [&#39;SimHei&#39;] # 能正确显示负号 p
gitlab登录失败，报错：This challenge page was accidentally cached by an intermediary and is no longer available.
设置时间 控制面板
后端开发常见错误
错误1：Request method ‘DELETE‘ not supported 错误还原：controller层有一个接口，访问该接口时报错：Request method ‘DELETE‘ not supported 错误原因：没有接收到前端传入的参数，修改为如下 参考 错误2：cannot r
docker常见错误
错误1：启动docker镜像时报错：Error response from daemon: driver failed programming external connectivity on endpoint quirky_allen 解决方法：重启docker -&gt; systemctl r
idea常见错误
错误1：private field ‘xxx‘ is never assigned 按Altʾnter快捷键，选择第2项 参考：https://blog.csdn.net/shi_hong_fei_hei/article/details/88814070 错误2：启动时报错，不能找到主启动类 #
pip安装依赖失败
报错如下，通过源不能下载，最后警告pip需升级版本 Requirement already satisfied: pip in c:\users\ychen\appdata\local\programs\python\python310\lib\site-packages (22.0.4) Coll
maven常见错误
错误1：maven打包报错 错误还原：使用maven打包项目时报错如下 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.2.0:resources (default-resources)
cloud项目中常见错误
错误1：服务调用时报错 服务消费者模块assess通过openFeign调用服务提供者模块hires 如下为服务提供者模块hires的控制层接口 @RestController @RequestMapping(&quot;/hires&quot;) public class FeignControl
springboot常见错误
错误1：运行项目后报如下错误 解决方案 报错2：Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project sb 解决方案：在pom.
springmvc拦截器中使用redisTemplate报空指针异常
参考 错误原因 过滤器或拦截器在生效时，redisTemplate还没有注入 解决方案：在注入容器时就生效 @Component //项目运行时就注入Spring容器 public class RedisBean { @Resource private RedisTemplate&lt;String
vite报错：npm ERR! command C:WINDOWSsystem32cmd.exe /d /s /c C:UsersychenAppDataLocalTempnpx-dde1c848.cmd
使用vite构建项目报错 C:\Users\ychen\work&gt;npm init @vitejs/app @vitejs/create-app is deprecated, use npm init vite instead C:\Users\ychen\AppData\Local\npm-
pythonJavaScriptjavaHTMLPHPreactjsC#AndroidCSSNode.jssqlrpython-3.xMysqLjQueryc++pandasFlutterangularIOSdjangolinuxswifttypescript路由器JSON路由器设置无线路由器h3c华三华三路由器设置华三路由器电脑软件教程arraysdocker软件图文教程Cvue.jslaravelspring-boot