如何解决线程安全日志记录类的实现
| 以下是实现相当简单的线程安全日志记录类的正确方法吗？ 我知道我从来没有明确地关闭ѭ0，这会是一个问题吗？ 最初使用TextWriter.Synchronized
public static class Logger
{
static readonly TextWriter tw;
static Logger()
{
tw = TextWriter.Synchronized(File.AppendText(SPath() + \"\\\\Log.txt\"));
}
public static string SPath()
{
return ConfigManager.GetAppSetting(\"logPath\");
}
public static void Write(string logMessage)
{
try
{
Log(logMessage,tw);
}
catch (IOException e)
{
tw.Close();
}
}
public static void Log(string logMessage,TextWriter w)
{
w.WriteLine(\"{0} {1}\",DateTime.Now.ToLongTimeString(),DateTime.Now.ToLongDateString());
w.WriteLine(\" :\");
w.WriteLine(\" :{0}\",logMessage);
w.WriteLine(\"-------------------------------\");
// Update the underlying file.
w.Flush();
}
}
解决方法
在这里，我将采用与其他答案完全不同的方法，并假设您实际上是想学习如何编写更好的线程感知代码，并且没有从我们这里寻求第三者的建议（即使您可能最终会得到建议）使用一个。）
正如其他人所说，您正在创建一个线程安全的“ 0”，这意味着对WriteLine的调用是线程安全的，这并不意味着一堆对
WriteLine
TextWriter
Logger.Log
WriteLine
lock
private static readonly object _syncObject = new object();
public static void Log(string logMessage,TextWriter w) {
// only one thread can own this lock,so other threads
// entering this method will wait here until lock is
// available.
lock(_syncObject) {
w.WriteLine(\"{0} {1}\",DateTime.Now.ToLongTimeString(),DateTime.Now.ToLongDateString());
w.WriteLine(\" :\");
w.WriteLine(\" :{0}\",logMessage);
w.WriteLine(\"-------------------------------\");
// Update the underlying file.
w.Flush();
}
}
Write
TextWriter
Log
Logger
Threadsafe
public static class Logger
{
static readonly object _locker = new object();
public static void Log(string logMessage)
{
try
{
var logFilePath = Path.Combine(@\"C:\\YourLogDirectoryHere\",\"Log.txt\");
//Use this for daily log files : \"Log\" + DateTime.Now.ToString(\"yyyy-MM-dd\") + \".txt\";
WriteToLog(logMessage,logFilePath);
}
catch (Exception e)
{
//log log-exception somewhere else if required!
}
}
static void WriteToLog(string logMessage,string logFilePath)
{
lock (_locker)
{
File.AppendAllText(logFilePath,string.Format(\"Logged on: {1} at: {2}{0}Message: {3}{0}--------------------{0}\",Environment.NewLine,DateTime.Now.ToLongDateString(),logMessage));
}
}
}
Logger.Log(\"Some important event has occurred!\");
public void Log(TraceEventType eventType,string message)
{
this.traceSource.TraceEvent(eventType,message);
this.traceSource.Flush();
}
<system.diagnostics>
<sources>
<source name=\"Sample\" switchValue=\"Information,ActivityTracing\">
<listeners>
<add name=\"file\"
initializeData=\"C:\\temp\\Sample-trace.log\"
traceOutputOptions=\"DateTime\"
type=\"System.Diagnostics.TextWriterTraceListener,System,Version=2.0.0.0,Culture=neutral,PublicKeyToken=b77a5c561934e089\"/>
</listeners>
</source>
</sources>
版权声明：本文内容由互联网用户自发贡献，该文观点与技术仅代表作者本人。本站仅提供信息存储空间服务，不拥有所有权，不承担相关法律责任。如发现本站有涉嫌侵权/违法违规的内容， 请发送邮件至 dio@foxmail.com 举报，一经查实，本站将立刻删除。